Skip to content
This repository has been archived by the owner on Jan 7, 2024. It is now read-only.

Use the given timeout value for proxy calls #114

Closed
kushaldas opened this issue Mar 30, 2020 · 2 comments
Closed

Use the given timeout value for proxy calls #114

kushaldas opened this issue Mar 30, 2020 · 2 comments

Comments

@kushaldas
Copy link
Contributor

Right now we don't pass the given timeout value to the proxy object calls. We should pass the value to the proxy object.

Related PR in the securedrop-proxy freedomofpress/securedrop-proxy#69

kushaldas added a commit that referenced this issue Mar 30, 2020
Now we are passing the given timeout value in any API call to
the proxy object in Qubes.
@kushaldas
Copy link
Contributor Author

While working on this I figured somehow in the past we missed to update the test cases for sdk in many places, causing many different new errors. Trying to debug those one by one.

@kushaldas
Copy link
Contributor Author

kushaldas commented Mar 30, 2020

https://github.com/freedomofpress/securedrop-proxy/blob/master/securedrop_proxy/proxy.py#L272-L278

When we send in an unencrypted error to the securedrop server, it replies with a "BAD REQUEST 400" and a JSON message. We were dependent on that error message before to provide the information that it missing encryption, but, that is now not happing due to the code mentioned above in the proxy. In particular this line, https://github.com/freedomofpress/securedrop-proxy/blob/3a79ea4cdc7bddd13c8536184defb7a3f5c2f2d2/securedrop_proxy/proxy.py#L277

For now I will just modify the test for error in uncrypted reply for the same in APIProxy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant