This repository has been archived by the owner on Jan 7, 2024. It is now read-only.
Request compression of server responses #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable compressed responses from the API, once the SecureDrop server sends them.
eloquence
moved this from Ready for Review
to Near Term - SD Workstation
in SecureDrop Team Board
eloquence
moved this from Near Term - SD Workstation
to Discussion Points
in SecureDrop Team Board
|
(Adding to "Discussion Points" to check in on status of this PR.) |
|
Per discussion today, more research required here to investigate any security implications of enabling response compression server-side, but keeping open. |
eloquence
moved this from Discussion Points
to Near Term - SD Workstation
in SecureDrop Team Board
|
Since the research work makes up the bulk of this task and is tracked separately in freedomofpress/securedrop#5745, and this PR is getting very dated, I'm closing it for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send
Accept-Encodingheader to enable compressed responses.To be useful, requires that the server be configured to compress
application/json.