Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename securedrop-app-code-requirements.txt to just requirements.txt #6619

Closed
legoktm opened this issue Oct 12, 2022 · 0 comments · Fixed by #6695
Closed

Rename securedrop-app-code-requirements.txt to just requirements.txt #6619

legoktm opened this issue Oct 12, 2022 · 0 comments · Fixed by #6695
Assignees
@legoktm

Comments

@legoktm
Copy link
Member

legoktm commented Oct 12, 2022

As part of reproducible wheels (#5901), we're adopting the same workflow as the SDW packages. One gotcha is that the scripts (reasonably) expect the file to be named "requirements.txt".

Given that all the other files are already named with a prefix, it seems reasonable to move our real, production dependencies to plain "requirements.txt".
@legoktm legoktm self-assigned this Nov 2, 2022
legoktm added a commit that referenced this issue Nov 30, 2022
@legoktm
Rename securedrop-app-code-requirements.txt to requirements.txt
c04c227 
All of our reproducible wheels scripts in securedrop-builder expect the
file to be named "requirements.txt". Renaming this file seems like the
simplest option and it matches the convention that the unprefixed file
is the main production dependencies.

No dependencies are changed in this commit.

Fixes #6619.
@legoktm legoktm mentioned this issue Nov 30, 2022
Merged
7 tasks
legoktm added a commit that referenced this issue Nov 30, 2022
@legoktm
Rename securedrop-app-code-requirements.txt to requirements.txt
e70fb5e 
All of our reproducible wheels scripts in securedrop-builder expect the
file to be named "requirements.txt". Renaming this file seems like the
simplest option and it matches the convention that the unprefixed file
is the main production dependencies.

No dependencies are changed in this commit.

Fixes #6619.
legoktm added a commit that referenced this issue Dec 12, 2022
@legoktm
Rename securedrop-app-code-requirements.txt to requirements.txt
26423c9 
All of our reproducible wheels scripts in securedrop-builder expect the
file to be named "requirements.txt". Renaming this file seems like the
simplest option and it matches the convention that the unprefixed file
is the main production dependencies.

No dependencies are changed in this commit.

Fixes #6619.
legoktm added a commit that referenced this issue Dec 15, 2022
@legoktm
Rename securedrop-app-code-requirements.txt to requirements.txt
db08501 
All of our reproducible wheels scripts in securedrop-builder expect the
file to be named "requirements.txt". Renaming this file seems like the
simplest option and it matches the convention that the unprefixed file
is the main production dependencies.

No dependencies are changed in this commit.

Fixes #6619.
@cfm cfm closed this as completed in #6695 Jan 10, 2023
nathandyer pushed a commit that referenced this issue Mar 13, 2023
@legoktm @nathandyer
Rename securedrop-app-code-requirements.txt to requirements.txt
9b94406 
All of our reproducible wheels scripts in securedrop-builder expect the
file to be named "requirements.txt". Renaming this file seems like the
simplest option and it matches the convention that the unprefixed file
is the main production dependencies.

No dependencies are changed in this commit.

Fixes #6619.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@legoktm legoktm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reorganize and refactor requirements.txt files freedomofpress/securedrop
1 participant
@legoktm