Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set reply UUID #3958

Merged
merged 3 commits into from
Dec 7, 2018
Merged

Set reply UUID #3958

merged 3 commits into from
Dec 7, 2018

Conversation

heartsucker
Copy link
Contributor

Status

Ready for review

Description of Changes

Fixes #3957

Allow API consumer to set the Reply.uuid in the request to allow clients to easily track in-flight message in their own cache/db.

Testing

make test TESTFILES=tests/test_journalist_api.py::test_set_reply_uuid

Also play with the api some?

Deployment

This is a non-breaking change to the API.

Checklist

If you made changes to the server application code:

  • Linting (make ci-lint) and tests (make -C securedrop test) pass in the development container

@codecov-io
Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #3958 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3958      +/-   ##
===========================================
+ Coverage    84.62%   84.64%   +0.01%     
===========================================
  Files           43       43              
  Lines         2739     2754      +15     
  Branches       296      298       +2     
===========================================
+ Hits          2318     2331      +13     
- Misses         354      355       +1     
- Partials        67       68       +1
Impacted Files Coverage Δ
securedrop/securedrop/journalist_app/api.py 94.89% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196d766...d14677a. Read the comment docs.

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from visual review of the diff, lgtm - this just needs a doc update and then it's good to go

@heartsucker heartsucker merged commit fe62e35 into develop Dec 7, 2018
@heartsucker heartsucker deleted the set-reply-uuid branch December 7, 2018 09:48
@emkll emkll mentioned this pull request Feb 19, 2019
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants