-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set reply UUID #3958
Set reply UUID #3958
Conversation
745decd
to
9971a13
Compare
9971a13
to
d14677a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3958 +/- ##
===========================================
+ Coverage 84.62% 84.64% +0.01%
===========================================
Files 43 43
Lines 2739 2754 +15
Branches 296 298 +2
===========================================
+ Hits 2318 2331 +13
- Misses 354 355 +1
- Partials 67 68 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from visual review of the diff, lgtm - this just needs a doc update and then it's good to go
274f4c0
to
7846882
Compare
Status
Ready for review
Description of Changes
Fixes #3957
Allow API consumer to set the
Reply.uuid
in the request to allow clients to easily track in-flight message in their own cache/db.Testing
make test TESTFILES=tests/test_journalist_api.py::test_set_reply_uuid
Also play with the api some?
Deployment
This is a non-breaking change to the API.
Checklist
If you made changes to the server application code:
make ci-lint
) and tests (make -C securedrop test
) pass in the development container