-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added alert to admin interface of instances still on Trusty after Mar 4 #4055
Added alert to admin interface of instances still on Trusty after Mar 4 #4055
Conversation
b84627b
to
16a9889
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16a9889
to
08587b6
Compare
@kushaldas apologies, was getting caught out by apparmor rules - works now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now things are working as intended. I will wait for others to approve the text in the banner though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zenmonkeykstop this looks great. Functional testing in staging VM looks good to me, the apparmor profiles seem to work well. Otherwise, I've left a couple minor comments inline.
I'll let others chime in on the final wording, but it sounds good to me.
2abeff7
to
4aaa0d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran through the full test suite for both dev and staging environments. Good to go.
Status
Ready for review
Description of Changes
Fixes #4027. Adds a red bar at the top of the page for logged-in users of the Journalist Interface, warning them that their instance's server OS is EOL and must be upgraded. This message only appears if the system date is Mar 4 2019 or later and the OS version string is not "16.04"
Visually, the bar element should match the mockup in #4027 with the exception of the shade of red used - as coded, it uses the red warning color predefined in the application's stylesheets.
Testing
Testing in a development environment
The date for the alert to start appearing, and the OS version to test for, are set in
journalist_app/__init__.py
:The simplest way to test the alert behaviour is to modify these config settings and restart the Journalist Interface application.
Testing in staging
securedrop/journalist_app/__init__.py
to yesterday, and create a (Trusty) staging environment withmake build-debs && make staging
. Verify that the warning is displayedsecuredrop/journalist_app/__init__.py
to yesterday, and create a (Trusty) staging environment with `make build-debs && make staging. Verify that the warning is displayed.securedrop/journalist_app/__init__.py
to yesterday, and create a (Trusty) staging environment withmake build-debs && molecule converge -s libvirt-staging-xenial
. Verify that the warning is not displayed.Checklist
If you made changes to the server application code:
make ci-lint
) and tests (make -C securedrop test
) pass in the development containerIf you made non-trivial code changes: