[xenial] run haveged process confined by AppArmor #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two issues causing haveged to run unconfined on Xenial: 1. The AppArmor profile needed updating to whitelist rw for the PID file that haveged uses [0]. 2. The haveged service needed to be configured to start running only after AppArmor is running [1, 2]. [0] https://bugs.launchpad.net/ubuntu/+source/haveged/+bug/1708674 [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=824179 [2] #4098
redshiftzero
requested review from
conorsch,
kushaldas and
msheiny
as code owners
kushaldas
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4098.
Changes proposed in this pull request:
Testing
(the trusty CI staging job and the testinfra test modified in this PR should sufficiently test for trusty)
Xenial
make staging-xenialcompletes without errorsudo aa-statusreports 0 processes running unconfinedDeployment
Enforcing this via ansible playbook since they will be ran as part of the Xenial upgrade
Checklist
If you made changes to the system configuration:
If you made non-trivial code changes: