Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade scenario #4126

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Fix upgrade scenario #4126

merged 2 commits into from
Feb 12, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Feb 12, 2019

Status

Ready for review

Description of Changes

Fixes #4125

Testing

Run the upgrade testing scenario and ensure it completes successfully:

rm -r build/*
make build-debs
make upgrade-start
make upgrade-test-local
  • make upgrade-test-local completes without error on this branch.

Deployment

Dev env only

Checklist

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

This is required for testing upgrades from versions <= 0.11.1 to 0.12.0-rc0+ because the tor-apt repo was removed. It is needed to properly configure the boxes that are to be upgraded.
@codecov-io
Copy link

Codecov Report

Merging #4126 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4126   +/-   ##
========================================
  Coverage    84.77%   84.77%           
========================================
  Files           43       43           
  Lines         2779     2779           
  Branches       303      303           
========================================
  Hits          2356     2356           
  Misses         355      355           
  Partials        68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f6ea2...2b5aefe. Read the comment docs.

Copy link
Contributor

@heartsucker heartsucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through the test plan and this looks good to me.

@heartsucker heartsucker merged commit 8ebbfdb into develop Feb 12, 2019
@heartsucker heartsucker deleted the fix-upgrade-scenario branch February 12, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants