Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tor to 0.4.4.6 #5648

Merged
merged 3 commits into from Nov 24, 2020
Merged

Update Tor to 0.4.4.6 #5648

merged 3 commits into from Nov 24, 2020

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Nov 24, 2020

Status

Ready for review

Description of Changes

Towards #5624 .
Closes #5649 ?

Testing

  • Updated tor signing key is valid, only subkey was updated
  • make fetch-tor-debs is working as expected, for both xenial and focal

Deployment

These packages will be deployed once the deb packages are uploaded apt.freedom.press.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

Subkey 74A941BA219EC810 expired on 2020-11-23
zenmonkeykstop
zenmonkeykstop previously approved these changes Nov 24, 2020
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version and key are updated.

Looks good, ship it (once flaky CI passes).

@zenmonkeykstop zenmonkeykstop moved this from Ready for Review to Under Review in SecureDrop Team Board Nov 24, 2020
@zenmonkeykstop zenmonkeykstop merged commit 5e5baa8 into develop Nov 24, 2020
SecureDrop Team Board automation moved this from Under Review to Done Nov 24, 2020
@eloquence eloquence added this to the 1.7.0 milestone Jan 5, 2021
@kushaldas kushaldas mentioned this pull request Jan 18, 2021
22 tasks
@zenmonkeykstop zenmonkeykstop deleted the 5624-tor-0446 branch July 21, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Updater tests are failing in CI
3 participants