Remove "Refresh codename" feature #6195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice, this feature has potential for user confusion, as a critical step of the submission process while delivering minimal end user value. One key motivation for this feature has been the occasional generation of problematic words in codenames. We have already iterated over the wordlists several times, and will continue to do so. Reloading will also continue to work just fine.
eloquence
commented
Dec 10, 2021
| @@ -47,7 +47,7 @@ def _source_clicks_submit_documents_on_homepage(self): | |||
| assert self._is_on_generate_page() | |||
|
|
|||
| def _source_regenerates_codename(self): | |||
| self.safe_click_by_id("regenerate-submit") | |||
| self.driver.refresh() | |||
There was a problem hiding this comment.
From my read, test_refreshed_duplicate_generate_pages is still useful even without the "refresh codename" feature (for example, it tests that the user is redirected to the lookup page when they have already logged in in a separate tab), so I have simply altered the behavior here to reload the page instead.
|
For context, @zenmonkeykstop, @ninavizz and I identified this as a potential "quick win" on the path towards improving the source user experience, prior to bigger changes such as overhauling/inverting the authentication flow and retiring the term "codename". |
zenmonkeykstop
approved these changes
Dec 10, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
Removes the "Refresh" icon from the page that presents a source with a seven word codename. In practice, this feature has potential for user confusion, as it introduces complexity to a critical step of the submission process while delivering minimal end user value.
One key motivation for this feature has been the occasional generation of problematic words in codenames. We have already iterated over the wordlists several times, and will continue to do so.
Testing
Deployment
Note that this PR removes an image from the package, which is also removed from the AppArmor allow-list.
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you added or removed a file deployed with the application:
If you made non-trivial code changes:
Choose one of the following: