Update pytz to 2022.2.1 #6571
Merged
Update pytz to 2022.2.1 #6571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aside from getting 5 years worth of timezone database updates, the older release is problematic because it shipped a zip source release rather than a gzipped tarball, which our reproducible wheel scripts expect. Fixes #6569.
5 tasks
eloquence
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Looks good to me. I compared the display of timestamps in the Journalist Interface across all languages and did not spot any differences whatsoever. The JI displays dates in UTC, and makes calls to babel's dates module that do not specify a timezone. Other timezone conversions are handled via Python's datetime module. So I'm not sure that our use of pytz gets us anything right now, it's just a dependency of babel, but good to keep updated nonetheless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Aside from getting 5 years worth of timezone database updates, the older release is problematic because it shipped a zip source release rather than a gzipped tarball, which our reproducible wheel scripts expect.
Fixes #6569.
Testing
Deployment
Any special considerations for deployment? No.
Checklist
make lint) and tests (make test) pass in the development container