Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(test): suggest a workaround for the slow admin test suite #7181

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

cfm
Copy link
Member

@cfm cfm commented Jun 13, 2024

Status

Ready for review

Description of Changes

"Fixes with documentation" the fact that the admin test suite runs in a container that's rebuilt very slowly on every change. Given how rarely we interact with it directly (as opposed to in CI), I don't think that's worth fixing, but it is worth hinting at a quality-of-life workaround.

Refs #6897.

Testing

  • Visual review.

Deployment

Development/test-only.

We're unlikely to invest the time in optimizing the admin test suite's
container as we've done for SecureDrop.  Barring that optimization,
others may find that this hint saves them some time.
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-referenced with the issue I filed about this last year 😭 but this is better than the status quo. Thanks!

@legoktm legoktm merged commit aa34ea7 into develop Jun 13, 2024
17 checks passed
@legoktm legoktm deleted the admin-test-hint branch June 13, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants