nss_checker: Make user/group names platform-dependent #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
have to fix |
stanislavlevin
force-pushed
the
nss_names
branch
from
39b1cea
to
faf9758
Compare
rcritten
reviewed
Feb 15, 2022
tests/test_ipa_nss.py
Outdated
| def test_ipaapi_group_ok(self, mock_grp): | ||
| mock_grp.return_value = make_group('apache', ('apache', 'ipaapi',)) | ||
|
|
||
| def test_ipaapi_group_ok(self): |
There was a problem hiding this comment.
This assumes that the test system is configured properly doesn't it?
There was a problem hiding this comment.
Tests require freeipa-server RPM package which pulls apache as well, both have RPM post-scripts creating system users for them. Thus, IPA (including underlying components) has all the needed system users upon installation, the configuration is not required. So, actually mocking is required only for negative test cases. But adding a mocking for the existing group is not a big deal.
|
Just the one question, otherwise this looks great. |
stanislavlevin
force-pushed
the
nss_names
branch
from
faf9758
to
257d070
Compare
- make use of ipaplatform for user/group names to avoid hardcoded values - correct mocking in tests There were several issues with these tests: - mocking of builtins on global level is discouraged, mock on target module level instead - wrong mocked group, `IPAGroupMemberCheck` checks if apache user has supplementary group `ipaapi`, while test mocked `apache` group - wrong mocked `struct_group`, it should include user names having given supplementary group, not a primary one: ipaapi: (ipaapi, apache) => ipaapi: (apache,) Fixes: freeipa#247 Signed-off-by: Stanislav Levin <slev@altlinux.org>
- make use of ipaplatform for user/group names to avoid hardcoded values Fixes: freeipa#247 Signed-off-by: Stanislav Levin <slev@altlinux.org>
stanislavlevin
force-pushed
the
nss_names
branch
from
257d070
to
01a3852
Compare
|
added platform dependent changes for |
|
PR looks good, thanks. ack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User/group names were hardcoded, this broke ipaplatforms having
different names.
Fixes: #247
Signed-off-by: Stanislav Levin slev@altlinux.org