Parse Apache log etime and display average per command #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flo-renaud
reviewed
Apr 28, 2021
There was a problem hiding this comment.
Hi @rcritten
thanks for the PR. Please find inline comments
contrib/perflog
Outdated
| super(parselog, self).run() | ||
|
|
||
| if not is_ipa_configured(): | ||
| logger.error("IPA client is not configured on this system.") |
There was a problem hiding this comment.
The message should be "IPA server is not configured on this system".
There was a problem hiding this comment.
You probably missed this comment: should be "IPA is not configured".
flo-renaud
reviewed
Apr 30, 2021
There was a problem hiding this comment.
Hi @rcritten,
thanks for the update. Please find an additional inline comment.
flo-renaud
reviewed
May 6, 2021
There was a problem hiding this comment.
@rcritten please find 2 minor inline nitpicks, other comments already addressed.
contrib/perflog
Outdated
| super(parselog, self).run() | ||
|
|
||
| if not is_ipa_configured(): | ||
| logger.error("IPA client is not configured on this system.") |
There was a problem hiding this comment.
You probably missed this comment: should be "IPA is not configured".
Including execution time (etime) was added in commit 4d716d3 This is a parser that will collect API executions and average them by command. If > 5 requests of the same type then the fastest and slowest results will be dropped to try to smooth the average. These averages will be used for two purposes: 1. Identify potential bottlenecks in API performance 2. Provide a baseline so that future performance changes can be measured. It is included in contrib because this is not going to be shipped with a distribution but is useful to have with the code. A sample execution is: Successful commands: Mean user_show: 12234152.5 of 2 executions Mean command_defaults: 3284363.0 of 3 executions Mean user_add: 594369554.5 of 2 executions Exceptions: Mean user_del: 232540327 ns of 2 executions The parselog command was successful Times are in nanoseconds. https://pagure.io/freeipa/issue/8809 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
|
@rcritten thanks for the update, works for me. ACK for when PRCI completes |
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including execution time (etim) was added in commit
4d716d3
This is a parser that will collect API executions and
average them by command.
If > 5 requests of the same type then the fastest and slowest
results will be dropped to try to smooth the average.
These averages will be used for two purposes:
measured.
It is included in contrib because this is not going to be shipped
with a distribution but is useful to have with the code.
A sample execution is:
Mean user_show: 12234152.5 of 2 executions
Mean command_defaults: 3284363.0 of 3 executions
Mean user_add: 594369554.5 of 2 executions
The parselog command was successful
Times are in nanoseconds.
https://pagure.io/freeipa/issue/8809
Signed-off-by: Rob Crittenden rcritten@redhat.com