Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-9] Parse Apache log etime and display average per command #5757

Closed
wants to merge 1 commit into from

Conversation

rcritten
Copy link
Contributor

@rcritten rcritten commented May 6, 2021

This PR was opened automatically because PR #5717 was pushed to master and backport to ipa-4-9 is required.

Including execution time (etime) was added in commit
4d716d3

This is a parser that will collect API executions and
average them by command.

If > 5 requests of the same type then the fastest and slowest
results will be dropped to try to smooth the average.

These averages will be used for two purposes:

1. Identify potential bottlenecks in API performance
2. Provide a baseline so that future performance changes can be
   measured.

It is included in contrib because this is not going to be shipped
with a distribution but is useful to have with the code.

A sample execution is:

Successful commands:
 Mean user_show: 12234152.5 of 2 executions
 Mean command_defaults: 3284363.0 of 3 executions
 Mean user_add: 594369554.5 of 2 executions
Exceptions:
 Mean user_del: 232540327 ns of 2 executions
The parselog command was successful

Times are in nanoseconds.

https://pagure.io/freeipa/issue/8809

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
@rcritten
Copy link
Contributor Author

rcritten commented May 6, 2021

PR was ACKed automatically because this is backport of PR #5717. Wait for CI to finish before pushing. In case of questions or problems contact @rcritten who is author of the original PR.

@rcritten rcritten added the ack Pull Request approved, can be merged label May 6, 2021
@flo-renaud
Copy link
Contributor

ipa-4-9:

  • bae02a7 Parse Apache log etime and display average per command

@flo-renaud flo-renaud added the pushed Pull Request has already been pushed label May 7, 2021
@flo-renaud flo-renaud closed this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants