Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scrapers.utils): improve expected content type check #3938

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

grossir
Copy link
Contributor

@grossir grossir commented Apr 3, 2024

Helps fix #3937

  • convert site.expected_content_types to lower()
  • remove ";charset=utf-8" or similar specifications from returned content type
  • add a test for "charset" content type

Helps fix freelawproject#3937

- convert site.expected_content_types to lower()
- remove ";charset=utf-8" or similar specifications from returned content type
- add a test for "charset" content type
Copy link
Contributor

@flooie flooie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@flooie flooie enabled auto-merge April 5, 2024 16:22
@flooie flooie merged commit 039324e into freelawproject:main Apr 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnexpectedContentTypeError false positives
2 participants