Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audio.transcribe): mark failed when BadRequestError is raised #4117

Merged

Conversation

grossir
Copy link
Contributor

@grossir grossir commented Jun 14, 2024

Set audio.stt_status = Audio.STT_FAILED on BadRequestError. The error has a message like
'The audio file could not be decoded or its format is not supported' So as to avoid naive retries of bad audio files

Set `audio.stt_status = Audio.STT_FAILED` on BadRequestError.
The error has a message like
'The audio file could not be decoded or its format is not supported'
So as to avoid naive retries of bad audio files
Copy link

sentry-io bot commented Jun 14, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: cl/audio/tasks.py

Function Unhandled Issue
transcribe_from_open_ai_api OpenAIError: The api_key client option must be set either by passing api_key to the client or by setting the O... ...
Event Count: 20
transcribe_from_open_ai_api AttributeError: 'Audio' object has no attribute 'name' cl.audio.tasks in transcribe_from_open_...
Event Count: 1
transcribe_from_open_ai_api KeyError: 'word' cl.audio.tasks in transcribe_fro...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@ERosendo
Copy link
Contributor

LGTM :shipit:

@grossir grossir merged commit 8ec601e into freelawproject:main Jun 14, 2024
9 checks passed
Copy link

sentry-io bot commented Jun 19, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AttributeError: 'dict' object has no attribute 'request' cl.audio.tasks.transcribe_from_open_ai_api View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants