Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to manifest v3 #333

Closed
mlissner opened this issue Feb 15, 2023 · 5 comments
Closed

Move to manifest v3 #333

mlissner opened this issue Feb 15, 2023 · 5 comments

Comments

@mlissner
Copy link
Member

We're going to have to do this eventually, so this is just a place to put some notes. Here are the first two notes from me:

  1. We have a label for this:

manifestv3

  1. There's a boilerplate that I came across today that might be useful:

https://github.com/fstanis/webextensions-webpack-boilerplate

No idea if it's up to date, but it'd be great if it were.

@mlissner
Copy link
Member Author

A few more comments:

  1. Nick Sethi actually has a branch that does MV3. It might be easier to use his branch or it might be easier to go from scratch. I don't know, but we should at least evaluate it. I think he developed the extension from scratch in his branch. 😲

  2. Before we do this, we should evaluate this issue: Using exportInstance and importInstance goes against convention and causes issues #237 and decide how it factors into MV3. I think we'll resolve it without trying just by doing MV3-like architecture, but let's make sure.

@mlissner
Copy link
Member Author

mlissner commented Aug 1, 2024

Two developments here:

  1. Google is now showing a banner warning people about RECAP. I can't seem to find it, but a few people have reported it.

  2. A large gov't body just asked why we don't have RECAP in the MS Edge store, which, per Add RECAP to the MS Edge store #368, is because it's not on Manifest v3.

@mlissner
Copy link
Member Author

Feedback from installing it, so far. Two things:

image

  1. The icon is busted there. That could certainly be because of OS-level sandboxing, so if nobody else sees it, it's probably just me.
  2. There's a warning still, but perhaps it's expected?

@ERosendo
Copy link

@mlissner should we close this issue? After merging freelawproject/recap-chrome#387, the extension is all set with Manifest V3.

@mlissner
Copy link
Member Author

Yep!! Thank you for your hard work!

@github-project-automation github-project-automation bot moved this from 🔎In Review to Done in @erosendo's backlog Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants