Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename observeWhileInState to collectWhileInState #63

Closed
sockeqwe opened this issue Feb 12, 2020 · 0 comments
Closed

Rename observeWhileInState to collectWhileInState #63

sockeqwe opened this issue Feb 12, 2020 · 0 comments

Comments

@sockeqwe
Copy link
Collaborator

Renaming observeWhileInState() to collectWhileInState to be more aligned with flow.collect { ... }

Another interesting question would be though if we should do the same with
storewide observe(flow). Should it be renamed to collect(flow) which is could be misleading since flow.collect {...} is the way to call it. An alternative option is to rename observe(flow) to collectWhileStateMachineRuns(flow) or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant