Additional condition for on<Action> construct

[sockeqwe]

We already have inState<S>(additionalCondition = { ... }) and maybe it would be useful to add additionalCondition also to on<Action>.

Use case:

FlowRedux/sample/shared_code/src/commonMain/kotlin/com/freeletics/flowredux/sample/shared/MarkAsFavoriteStateMachine.kt

Lines 51 to 59 in 1387be5

	private fun resetErrorState(action: RetryToggleFavoriteAction, state: State<GithubRepository>): ChangeState<GithubRepository> {
	return if (action.id != state.snapshot.id) {
	// Since all active MarkAsFavoriteStateMachine receive this action
	// we need to ignore those who are not meant for this state machine
	state.noChange()
	} else {
	state.mutate { copy(favoriteStatus = FavoriteStatus.OPERATION_IN_PROGRESS) }
	}
	}

Where the on<Action> block should actually only be triggered when action.id == someId

Just leaving it here for a potential future addition / improvement.

[gabrielittner]

Wouldn't it be better to have the check inside the method for testability?

[gabrielittner]

@sockeqwe Any objections against closing this since we are adding the condition block and also are deprecating the additional condition overload from isInState?

[sockeqwe]

Yep, sounds good! Gabriel Ittner ***@***.***> schrieb am Mi., 31. Mai 2023, 03:45:

…

@sockeqwe <https://github.com/sockeqwe> Any objections against closing this since we are adding the condition block and also are deprecating the additional condition overload from isInState? — Reply to this email directly, view it on GitHub <#311 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEOPLTFZ3P4VIEPWDUDKSTXIZE4HANCNFSM5X3LDCMA> . You are receiving this because you were mentioned.Message ID: ***@***.***>