dashboard memory panel: show ECC status only when known #4027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecc presents as "ECC" or "non-ECC", but actually the system actually only knows "ECC" or "IDK, prolly not but maybe". dmidecode does not seem a reliable source for this information. It has been shown that ECC can be installed, configured, and enabled, and yet dmidecode can say that it is not. This change should only show the "(ECC)" in the panel when it knows there is ECC, and nothing when it isn't sure, instead of "(non-ECC)". See: * https://www.ixsystems.com/community/threads/truenas-web-ui-shows-non-ecc-but-ecc-is-used.84492/ * https://jira.ixsystems.com/projects/NAS/issues/NAS-105991
erincodepirate
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ecc presents as "ECC" or "non-ECC", but actually
the system actually only knows "ECC" or "IDK, prolly not but maybe".
dmidecode does not seem a reliable source for this information.
It has been shown that ECC can be installed, configured, and enabled,
and yet dmidecode can say that it is not.
This change should only show the "(ECC)" in the panel when it knows
there is ECC, and nothing when it isn't sure, instead of "(non-ECC)".
See: