Skip to content

Conversation

AlanFnz
Copy link
Member

@AlanFnz AlanFnz commented Aug 5, 2025

What

Fixed an issue where the Select component would still show padding at the top when hideLabel={true} was set, causing unnecessary whitespace.

How

  • Added $hideLabel prop to InnerWrapper to conditionally control padding
  • Updated SelectTriggerWithRef to pass this prop through
  • Modified CSS to only apply top padding when labels are visible

Copy link
Member

@renejfc renejfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

pkg-pr-new bot commented Aug 5, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@freenow/wave@552

commit: ee4a11a

@AlanFnz AlanFnz merged commit 7a8a7fe into freenowtech:main Aug 5, 2025
7 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 5, 2025
### [2.41.1](v2.41.0...v2.41.1) (2025-08-05)

### Bug Fixes

* select component hide label style ([#552](#552)) ([7a8a7fe](7a8a7fe))
Copy link
Contributor

github-actions bot commented Aug 5, 2025

🎉 This PR is included in version 2.41.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants