sbt-freestyle cross sbt versioned #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
reviewed
Oct 12, 2017
| val sourceFile = (baseDirectory in LocalRootProject).value / "README.md" | ||
| val targetFile = crossTarget.value / s"${name.value}-javadoc.jar" | ||
|
|
||
| IO.copy(Seq(sourceFile -> targetFile), CopyOptions().withOverwrite(true)).toSeq |
There was a problem hiding this comment.
The 0.13 method is still available in sbt 1: https://github.com/sbt/io/blob/v1.0.0/io/src/main/scala/sbt/io/IO.scala#L587-L589
There was a problem hiding this comment.
CopyOptions is also available in any other location?
There was a problem hiding this comment.
No CopyOptions is sbt 1 only. What I meant is you could use
IO.copy(Seq(sourceFile -> targetFile), overwrite = true).toSeqin both sbt 0.13 and sbt 1 and avoid the extra source code files/directories.
There was a problem hiding this comment.
Got it.
However, now I recall why I had to split them up into different pieces of code. IO.copy method signature are not compatible among sbt 0.13 and 1.x.
- 0.13 (3 arguments):
https://github.com/sbt/sbt/blob/0.13/util/io/src/main/scala/sbt/IO.scala#L616 - 1.0 (4 arguments):
https://github.com/sbt/io/blob/v1.0.0/io/src/main/scala/sbt/io/IO.scala#L587
Am I missing something?
There was a problem hiding this comment.
No problem, thanks anyway :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin is now cross-versioned to sbt 1.0.1 and 0.13.16.