Migrate from turtles to droste #2
Conversation
src/main/scala/protobuf/schema.scala
Outdated
| val printSymbols = symbols.map({ case (s, i) => s"$s = $i;" }).mkString("\n") | ||
| val printAliases = aliases.map({ case (s, i) => s"$s = $i;" }).mkString("\n") | ||
|
|
||
| s""" |
There was a problem hiding this comment.
Here, you could use stripMargin?
s"""
|enum $name {
| $printOptions
| $printSymbols
| $printAliases
|}
""".stripMargin
src/main/scala/protobuf/schema.scala
Outdated
| case TMessage(name, fields, reserved) => | ||
| val printReserved = reserved.map(l => s"reserved " + l.mkString(", ")).mkString("\n ") | ||
| def printOptions(options: List[Option]) = | ||
| if (options.isEmpty) { |
There was a problem hiding this comment.
No need for braces in this if-then-else.
src/main/scala/protobuf/schema.scala
Outdated
| .map(f => s"""${f.tpe} ${f.name} = ${f.position}${printOptions(f.options)};""") | ||
| .mkString("\n ") | ||
| s""" | ||
| message $name { |
src/main/scala/protobuf/schema.scala
Outdated
|
|
||
| val printFields = | ||
| fields | ||
| .map(f => s"""${f.tpe} ${f.name} = ${f.position}${printOptions(f.options)};""") |
There was a problem hiding this comment.
I think that, for this line, a single-quoted string will suffice.
| proto.name, | ||
| proto.types.map(toFreestyle), | ||
| proto.messages.map( | ||
| msg => |
There was a problem hiding this comment.
I would extract this as a def toOperation function.
docs/src/main/tut/optimizations.md
Outdated
| ```scala | ||
| def nestedNamedTypesTrans[T](implicit T: Basis[Schema, T]): Trans[Schema, Schema, T] = Trans { | ||
| case TProduct(name, fields) => | ||
| TProduct[T]( |
There was a problem hiding this comment.
Here, I would extract the function of the map as a def, so as to get:
def ttt(f: Field[T]) = f.copy(tpe = namedTypes(T)(f.tpe))
TProduct[T](name, fields.map(tt) )| case TProduct(name, fields) => | ||
| TProduct[T]( | ||
| name, | ||
| fields.map { f: Field[T] => |
There was a problem hiding this comment.
Same as the comment for the optimize.md file.
| invariants.toList.mkString("Cop[", " :: ", ":: TNil]") | ||
| case TSum(name, fields) => | ||
| val printFields = fields.map(f => s"case object $f extends $name").mkString("\n ") | ||
| s""" |
| """ | ||
| case TProduct(name, fields) => | ||
| val printFields = fields.map(f => s"${f.name}: ${f.tpe}").mkString(", ") | ||
| s""" |
There was a problem hiding this comment.
Would the next three lines be the same as the following line?
"@message case class $name($printFields)"
src/main/scala/protobuf/schema.scala
Outdated
| if (options.isEmpty) { | ||
| "" | ||
| } else { | ||
| options.map(printOption).mkString(" [", ", ", "]") |
There was a problem hiding this comment.
In the mkString, I had some problem reading apart each quote and comma. It may be worth using named parameters:
mkString( start = " [" , sep = ", " , end = "]" ) 
docs/src/main/tut/optimizations.md
Outdated
| ``` | ||
|
|
||
| ```tut | ||
| ast[Mu[Schema]].transCataT(namedTypes) | ||
| val optimization = Optimize.namedTypes[Fix[Schema]] |
There was a problem hiding this comment.
You should be able to use Mu still, if you want.
There was a problem hiding this comment.
Yeah, IDK why I didn't see it in droste :) Thanks!
Use droste for recursion schemes