Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ath79-generic: (re)add support for archer-c60 #3034

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

ambassador86
Copy link
Contributor

This device was gone. I tried to use it with the smallbuffers wifi firmware and the device remained suprisingly stable. I whould also consider to add this at least with the broken flag, because I do not have a crowded test environment.
Test device: https://map.chemnitz.freifunk.net/#!v:m;n:50c7bf2cf5c8

  • Must be flashable from vendor firmware
    • Web interface
  • Must support upgrade mechanism
    • Must have working sysupgrade
      • Must keep/forget configuration (sysupgrade [-n], firstboot)
    • Gluon profile name matches autoupdater image name
      (lua -e 'print(require("platform_info").get_image_name())') -> tp-link-archer-c60-v1
  • Reset/WPS/... button must return device into config mode
  • Primary MAC address should match address on device label (or packaging)
    (https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages)
  • Wired network
    • should support all network ports on the device
    • must have correct port assignment (WAN/LAN)
  • Wireless network (if applicable)
    • Association with AP must be possible on all radios
    • Association with 802.11s mesh must work on all radios
    • AP+mesh mode must work in parallel on all radios
  • LED mapping
    • Power/system LED
    • Radio LEDs
      • Should map to their respective radio
      • Should show activity
    • Switch port LEDs
      • Should map to their respective port (or switch, if only one led present)
      • Should show link state and activity
  • Docs:
    • Added Device to docs/user/supported_devices.rst

@github-actions github-actions bot added 3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support labels Oct 25, 2023
@blocktrron
Copy link
Member

Archer C59 v1 has the same caveats, thus i think it is fine adding the device non-broken.

@ambassador86
Copy link
Contributor Author

I just saw in the build log, that the factory image becomes too big. Should I change my commit to only support sysupgrades? This whould allow users to install gluon after installing vanilla openwrt first.

@blocktrron
Copy link
Member

To be precise, it is not the factory image that becomes to big, it's the support-list "partition" / area:

2023-10-25T20:52:35.3002277Z support-list partition too big (more than 256 bytes): Success

This can be fixed either by expanding the partition, however I'm not sure if this has side-effects depending on the device.

I think it is fine to only build sysupgrade images for now. I just wanted to note this here, as it's not firmware image-size itself that is dangerously close to rendering the device unsupportable.

@ambassador86
Copy link
Contributor Author

Hello @blocktrron , good catch. I updated my PR and now lets see what the CI tells us.

@blocktrron blocktrron merged commit c2fc4e5 into freifunk-gluon:master Oct 26, 2023
13 checks passed
@ambassador86 ambassador86 deleted the archerC60 branch October 27, 2023 11:23
hafu pushed a commit to Freifunk-Potsdam/gluon that referenced this pull request Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants