feat: npm updates #653
Closed
feat: npm updates #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. |
|
@nwaldispuehl, I'm currently working on fixing the TypeScript protobuf files for the npm SDK. You managed to solve this problem before, iirc. Do you have any suggestions on how to tackle it again? |
|
quick fix by pinning the grpc-web version (baf0c3b). We might need to update https://github.com/Place1/protoc-gen-grpc-ts-web to use the new grpc.RpcError definitions as per https://github.com/grpc/grpc-web/releases/tag/1.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update npm deps to latest version