Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make devices -> clientConnectity -> mappingVariesByDestIP optional #25

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

frenck
Copy link
Owner

@frenck frenck commented Dec 9, 2021

Proposed Changes

Fixes this issue reported on the Home Assistant Discord in the #beta channel:

pydantic.error_wrappers.ValidationError: 1 validation error for Devices

devices -> xxxxx -> clientConnectivity -> mappingVariesByDestIP

  none is not an allowed value (type=type_error.none.not_allowed)

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Dec 9, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #25 (6531c1a) into main (9158ab8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files           4        4           
  Lines         100      100           
  Branches       14       14           
=======================================
  Hits           94       94           
  Misses          5        5           
  Partials        1        1           
Impacted Files Coverage Δ
src/tailscale/models.py 97.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9158ab8...6531c1a. Read the comment docs.

@frenck frenck merged commit db532a9 into main Dec 9, 2021
@frenck frenck deleted the frenck-2021-3202 branch December 9, 2021 08:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants