Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device created empty string #29

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Fix device created empty string #29

merged 1 commit into from
Dec 18, 2021

Conversation

frenck
Copy link
Owner

@frenck frenck commented Dec 18, 2021

Proposed Changes

Fixing device created being an empty string.

Debugged here: home-assistant/core#61599 (comment)

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Dec 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2021

Codecov Report

Merging #29 (1c2e14a) into main (6bc8c3a) will decrease coverage by 2.49%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   94.00%   91.50%   -2.50%     
==========================================
  Files           4        4              
  Lines         100      106       +6     
  Branches       14       15       +1     
==========================================
+ Hits           94       97       +3     
- Misses          5        8       +3     
  Partials        1        1              
Impacted Files Coverage Δ
src/tailscale/models.py 92.00% <50.00%> (-5.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc8c3a...1c2e14a. Read the comment docs.

@frenck frenck merged commit 4ffa1a6 into main Dec 18, 2021
@frenck frenck deleted the frenck-2021-3293 branch December 18, 2021 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants