Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inspections for unknown service calls in automations #600

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

frenck
Copy link
Owner

@frenck frenck commented Feb 10, 2024

Description

Adds a new inspection to Spook, that can find done service calls in automations and thus able to report on when unknown service calls are made.

Motivation and Context

Calling non-existing services cause errors and might go undetected. This allows Spook to be proactive and warn before use / run of the actual service.

This inspection will need refactoring in the future, as parts of this one are re-usable (e.g., for scripts).

How has this been tested?

By making the worst automations possible.

Screenshots (if appropriate):

CleanShot 2024-02-10 at 16 03 20@2x

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@frenck frenck added the new-feature New features or options. label Feb 10, 2024
Copy link

sonarcloud bot commented Feb 10, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@frenck frenck merged commit 89b1a7a into main Feb 10, 2024
15 checks passed
@frenck frenck deleted the frenck-2024-0215 branch February 10, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant