Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EventType annotations #733

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Add EventType annotations #733

merged 2 commits into from
Apr 23, 2024

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Apr 9, 2024

Description

SSIA. Required for 2024.05.

Motivation and Context

--

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

frenck
frenck approved these changes Apr 12, 2024
View reviewed changes
Copy link
Owner

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cdce8p 👍

../Frenck

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@frenck frenck added the refactor Improvement of existing code, not introducing new features. label Apr 16, 2024
@frenck frenck merged commit 03558da into frenck:main Apr 23, 2024
6 of 7 checks passed
@cdce8p cdce8p deleted the event-type branch April 23, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
refactor Improvement of existing code, not introducing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdce8p @frenck