Vlan fix #11
Merged
Vlan fix #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Is this something to be merged in? @jnfoster is apparently assigned. |
|
I lightly read this commit. It looks legit. I approve the merge. Anyone else want to hit the green button? |
|
Yes. We nominally started assigning people to pull reqs, and Nate and I spoke about this fix last week. Feel free to merge it in yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits rules that pop_vlan and don't match on VLAN into two rules: one that matches on vlan_any and pops, and one that matches on vlan_none and doesn't pop. Uses VLAN_VID = -1 to encode "vlan_any" to 0x04 backend.