-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenFlow 1.0 IP addr wildcards #50
Conversation
travis CI build failed due to tests. will investigate. |
one subtlety is that m_mask = None is equivalent to m_mask = Some 0 so change how Match.marshal works to make quicktest happy about this
Sweet. VInt abuse is starting to get super ugly. Int32m... -N On Thu, Dec 19, 2013 at 7:25 PM, Andrew Ferguson
|
agreed. it was a somewhat dirty move in the interest of efficiency :-/ ... my reasoning:
the "right" thing is probably going to require breaking the SDN.mli abstraction layer, so instead of:
you might have something like:
but that's going to cause a lot of code to break. (plus, you can't set a masked value in the action side; they only make sense in the match) so ... the overloading/abuse of VInt might make sense in the end. :-/ (note that OF 1.0 masking is based on shifting bits [page 21 of spec], while OXM is based on toggling bits on & off [sections A.2.3.4 and A.2.3.5 in the 1.3.1 spec] ... since you can sometimes convert between the two, providing both abstractions makes some sense, at least.) |
OpenFlow 1.0 IP addr wildcards
:-( |
We can back it out; I don't think anyone else is using it yet. @adferguson would you mind carrying the patch for a bit until we have a more general solution worked out? |
if that's what you all prefer, then go ahead. how long should I expect to wait for a more general solution? I ask because the more extra commits I'm carrying in my fork, the harder it is for me to contribute upstream. thank you. |
This is probably a good time to ask: what would it take to get you on -N On Thu, Jan 2, 2014 at 12:59 AM, Andrew Ferguson
|
hi Nate, great question. let me summarize my thinking:
anyway, I can easily send your group examples of our generated NetCore policies if that would be helpful. Andrew |
support for the IP address wildcards in OpenFlow 1.0's NW_SRC and NW_DST match fields.
our fork of NetCore uses this to support masking those fields in a match using a new "WildcardPartial" type. with this, we are able to implement a Layer 3 (IP) router.
thanks!
Andrew