Bug transacting with capacity should not require tokens to cover transaction cost #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2024 10:53
…1850-bug-transacting-with-capacity-should-not-require-tokens-to-cover-transaction-cost
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1851 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 56 56
Lines 4552 4552
=======================================
Hits 3776 3776
Misses 776 776 ☔ View full report in Codecov by Sentry. |
mattheworris
changed the title
JoeCap08055
reviewed
Jan 24, 2024
JoeCap08055
approved these changes
Jan 24, 2024
Co-authored-by: Joe Caputo <joseph.caputo@unfinished.com>
|
Only need to increase spec version |
…t-require-tokens-to-cover-transaction-cost
github-actions
bot
added
the
metadata-changed
mattheworris
deleted the
1850-bug-transacting-with-capacity-should-not-require-tokens-to-cover-transaction-cost
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to fix a frequency-tx-payment bug to allow capacity holders to transact when their free balance is less than the minimum balance, or Existential Deposit (ED).
Closes #1850
Discussion
withdraw_feecheck updated to usetotal_balanceinstead ofbalance, which ensures that if an account has capacity (frozen> 0) but has no available balance (free == frozen) transactions are still successfulHow to Test
Checklist