This repository has been archived by the owner on Feb 4, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #179, alternating headers do not hit anymore. This is because in case of a changed header, a new manifest is created instead of updating the old one.
A (small) manifest looks like this
This manifest contains hashes of all includes as a map. In order to fix this, multiple file hashes per include must be allowed.
Given that there are no sets in JSON, includeFiles will need to become a dictionary from string to lists of strings.
As long as the include content equals one of the hashes, everything is fine and the manifest can be used. The actual include content is encoded in the
includesContentToObjectMap
key.As soon as one include hash is not included, it becomes tricky: then we must deal with one manifest having multiple includes lists.
Dealing with multiple includes list per manifest is likely to be very painful. So I'll just start with a failing test.