Create Int and CGFloat variants for SteviaLayoutAnchor operators #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s4cha just to link you here. Looks like we have a version mismatch somewhere on the build job? |
|
@edulpn yeah don't mind the build job, it seems to be using Swift 5.2 and we need 5.3. |
|
Looking good ! Thanks a ton for taking the time to fix this for the rest of us 💯 🥇 |
|
This is now live in 5.1.1 https://github.com/freshOS/Stevia/releases/tag/5.1.1 |
|
My pleasure to help!
…On Thu, Nov 19, 2020, 09:15 Sacha DSO ***@***.***> wrote:
This is now live in 5.1.1
https://github.com/freshOS/Stevia/releases/tag/5.1.1
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#155 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDXETIXLNOY2IB4VMUUUD3SQUD4NANCNFSM4S3QH52A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on issue #153
SteviaLayoutAnchoroperators are lackingIntandCGFloatvariants of operators+and-.This PR adds operator variants that proxies to the
Doubleoperator like it's done withSteviaAttributeoperators.