Use softdelete to destroy session to prevent race condition and re-save #26
Conversation
| @@ -21,7 +21,7 @@ | |||
| "supertest": "^3.1.0", | |||
| "test-all-versions": "^4.1.0", | |||
| "tslint": "^5.8.0", | |||
| "typeorm": "^0.1.4", | |||
| "typeorm": "^0.2.34", | |||
There was a problem hiding this comment.
soft delete is already impl in typeorm, but we need to upgrade to 0.2.3+. ok to upgrade to latest?
| @@ -195,15 +237,26 @@ class Test { | |||
| this.express.get("/views", (req, res) => { | |||
| const session = nullthrows(req.session); | |||
|
|
|||
| res.json(session.views || 0); | |||
| res.json((session as any).views || 0); | |||
There was a problem hiding this comment.
I'm having some issues with TS... I had to add "as any" in many places... will remove as soon as I understand how.
| ) | ||
| // @ts-ignore | ||
| .then(async () => { | ||
| try { |
There was a problem hiding this comment.
the new logic seems very different but looking at the actual queries is very similar.
repository.save does a select, then decides to do an update vs an insert.
the most important thing, however, is to add a condition that destroyedAt IS NULL in the update. typeorm soft delete doesn't add this clause by default, unfortunately. Without this condition, during the race condition the session is updated (in the test above, views becomes 3).
Discussion in #25.