You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, thanks for contributing! Shouldn't it be if (interfaces[i].active && ["en0", "wifi"].indexOf(interfaces[i].name.toLocaleLowerCase()) >= 0) though? (We want to detect ethernet connection for the simulator).
Very sorry about the delay. You're dead right, of course. I've made the fix in my fix branch which still has the pull request outstanding if you'd like to accept it now.
Hey Freshplanet,
Thank you for releasing this fantastic ANE.
Just ran across a small problem though. In the method AirNetworkInfo::isNotNativeConnectedWithWIFI() (confusing name, btw), this line:
if (interfaces[i].active && ["en0", "wifi"].indexOf(interfaces[i].name.toLocaleLowerCase()))
will cause the method to return true even if WIFI is not connected (an indexOf() -1 will return true). Simply adding a >0 will fix this like so:
if (interfaces[i].active && ["en0", "wifi"].indexOf(interfaces[i].name.toLocaleLowerCase()) > 0)
I'll post a pull request later.
Thank you again for making this available. It's very useful.
-devon
The text was updated successfully, but these errors were encountered: