Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make support #130

Open
twe4ked opened this issue Apr 9, 2015 · 7 comments
Open

make support #130

twe4ked opened this issue Apr 9, 2015 · 7 comments

Comments

@twe4ked
Copy link
Member

twe4ked commented Apr 9, 2015

I think we've discussed this before, @jasoncodes, but I can't remember the outcome.
Could we have a --make option that cd's into the directory and runs make during the build?

# this would cd into the `~/.fresh/source/martanne` directory, run make,
# and link the resulting `vis` file to the bin directory.
fresh martanne/vis vis --make --bin

It could also take an argument that could be run in place of the --make command.
--make="make install".

@jasoncodes
Copy link
Member

I like the idea of supporting makefiles because they should run fast when there’s nothing to do. I wonder if we should go for something more generic though rather than --make? Something like --pre=make. I’m quite happy with --make though.

@twe4ked
Copy link
Member Author

twe4ked commented Apr 9, 2015

I don't mind --pre either. Perhaps --make could be a shortcut for --pre=make and --make=foo could be a shortcut for --pre=foo.

@jasoncodes
Copy link
Member

I’d rather just have one or the other. --make is fine.

@twe4ked
Copy link
Member Author

twe4ked commented Apr 11, 2015

I kind of like the idea of having both. It's only a few extra lines in _parse_fresh_dsl_args.
Edit: It could be an undocumented feature too.

@jasoncodes
Copy link
Member

It seems like diff-highlight now requires compilation. git/git@0c977db

Workaround is to --ref to the commit before this change or to do the ~~~compilation~~~ concatenation with multiple fresh calls. Note that a shebang needs to be added using --filter.

@iainjreid
Copy link

Hi guys, is this ready for use yet? I'm looking to pull down sources and compile them locally, and this looks like what I'm after!

@jasoncodes
Copy link
Member

Hi Iain. We are in the middle of a major refactor so have not completed this new feature yet. You could certainly check out the work in progress branch on #131 locally (run git checkout pre in ~/.fresh/source/freshshell/fresh) and give it a whirl though. We’d love your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants