This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
👌 IMPROVE: add whitelisting domain support #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravirajsubramanian
approved these changes
Jun 1, 2021
hemchander23
pushed a commit
to hemchander23/marketplace-sample-apps
that referenced
this pull request
Jun 3, 2021
* 👌 IMPROVE: add whitelisting domain support * 📖 DOC: list features demonstrated
hemchander23
added a commit
to hemchander23/marketplace-sample-apps
that referenced
this pull request
Jun 3, 2021
This reverts commit 2b451e4.
hemchander23
added a commit
to hemchander23/marketplace-sample-apps
that referenced
this pull request
Jun 3, 2021
* Revert "[DEVREL-1180] Refactor: Ticket-merger Freshdesk sample-app (freshworks#340)" This reverts commit c068b68. * Revert "👌 IMPROVE: add whitelisting domain support (freshworks#342)" This reverts commit 2b451e4. * Revert "🐛 FIX: whitelisting changes (freshworks#341)" This reverts commit bc05622. * Revert "[DEVREL-1166] Tweak: Spinner in Joke component (freshworks#331)" This reverts commit e42ea10.
hemchander23
pushed a commit
to hemchander23/marketplace-sample-apps
that referenced
this pull request
Jun 10, 2021
* 👌 IMPROVE: add whitelisting domain support * 📖 DOC: list features demonstrated
hemchander23
added a commit
to hemchander23/marketplace-sample-apps
that referenced
this pull request
Jun 10, 2021
* Revert "[DEVREL-1180] Refactor: Ticket-merger Freshdesk sample-app (freshworks#340)" This reverts commit c068b68. * Revert "👌 IMPROVE: add whitelisting domain support (freshworks#342)" This reverts commit 2b451e4. * Revert "🐛 FIX: whitelisting changes (freshworks#341)" This reverts commit bc05622. * Revert "[DEVREL-1166] Tweak: Spinner in Joke component (freshworks#331)" This reverts commit e42ea10.
hemchander23
added a commit
to hemchander23/marketplace-sample-apps
that referenced
this pull request
Jul 6, 2021
* Add newhire-onboarding-invites * Update README * [MP-10156] Newhire Onboarding Invites for freshteam * [MP-10156] Newhire Onboarding invites for freshteam * [MP-10156] name changed to newhire-onboarding-invites * [MP-10156] newhire-onboarding-invites * [MP-10156] generate operations fields * [DemoApps] Domain whitelisting, Iparams re-org * [DEVREL-1166] Tweak: Spinner in Joke component (freshworks#331) * Add: config-iparams-html-freshservice * New: config-iparams-html-freshservice * Twek: Joke Components Add: spinner as a loding sign during the API request phase * Tweak: Joke component at full_page * Update: Incorporated Review:1 * Update: Code Format * Update: Punchline via Dependency Injection * 🐛 FIX: whitelisting changes (freshworks#341) * 🐛 FIX: whitelisting changes * 📖 DOC: replace screenshots and features demonstrated * 👌 IMPROVE: add whitelisting domain support (freshworks#342) * 👌 IMPROVE: add whitelisting domain support * 📖 DOC: list features demonstrated * [DEVREL-1180] Refactor: Ticket-merger Freshdesk sample-app (freshworks#340) * ♻️ Refactor: Ticker Merger * rm: .gitignore * Security fixes for Demo Apps dir (#2) * Revert "[DEVREL-1180] Refactor: Ticket-merger Freshdesk sample-app (freshworks#340)" This reverts commit c068b68. * Revert "👌 IMPROVE: add whitelisting domain support (freshworks#342)" This reverts commit 2b451e4. * Revert "🐛 FIX: whitelisting changes (freshworks#341)" This reverts commit bc05622. * Revert "[DEVREL-1166] Tweak: Spinner in Joke component (freshworks#331)" This reverts commit e42ea10. * New line to files * `request_api` whitelisting: httpbin -> xkcd API * Fix `authentication_basic` app * `custom_entities` app fix * [DemoApps] Domain whitelisting, Iparams re-org * New line to files * [DEVREL-1166] Tweak: Spinner in Joke component (freshworks#331) * Add: config-iparams-html-freshservice * New: config-iparams-html-freshservice * Twek: Joke Components Add: spinner as a loding sign during the API request phase * Tweak: Joke component at full_page * Update: Incorporated Review:1 * Update: Code Format * Update: Punchline via Dependency Injection * 🐛 FIX: whitelisting changes (freshworks#341) * 🐛 FIX: whitelisting changes * 📖 DOC: replace screenshots and features demonstrated * 👌 IMPROVE: add whitelisting domain support (freshworks#342) * 👌 IMPROVE: add whitelisting domain support * 📖 DOC: list features demonstrated * [DEVREL-1180] Refactor: Ticket-merger Freshdesk sample-app (freshworks#340) * ♻️ Refactor: Ticker Merger * rm: .gitignore * Security fixes for Demo Apps dir (#2) * Revert "[DEVREL-1180] Refactor: Ticket-merger Freshdesk sample-app (freshworks#340)" This reverts commit c068b68. * Revert "👌 IMPROVE: add whitelisting domain support (freshworks#342)" This reverts commit 2b451e4. * Revert "🐛 FIX: whitelisting changes (freshworks#341)" This reverts commit bc05622. * Revert "[DEVREL-1166] Tweak: Spinner in Joke component (freshworks#331)" This reverts commit e42ea10. * `request_api` whitelisting: httpbin -> xkcd API * Fix `authentication_basic` app * `custom_entities` app fix * Fix log * Used aws-sdk/client-organizations * `config-iparams-html-freshdesk` whitelisting fix * `config-iparams-html-freshservice` whitelisting fix * `config-iparams-json-freshdesk` whitelisting fix * `config-iparams-json-freshservice` whitelisting * `config-placeholders-freshdesk` whitelisting fix * `custom_installation_page_app` whitelisting * `dynamic_iparams` disclaimer and whitelisting * `ticket_details_freshservice_app` Remove iparams_test_data * `Ticket_creator` app - scope, CDN, whitelisting fixes * `Github_Issue_Creator` CDN, bug fix, whitelisting, scope change * `config-iparams-json-freshservice` minor fixes Co-authored-by: Hamsini-Sivalenka <hamsini.sivalenka@freshworks.com> Co-authored-by: Teja Kummarikuntla <teja.kummarikuntla@freshworks.com> Co-authored-by: Shaik Saif Ali <saifali.shaik@freshworks.com>
hemchander23
added a commit
to hemchander23/marketplace-sample-apps
that referenced
this pull request
Jul 6, 2021
* [DEVREL-1008] Add: Voucher code generator sample /Demo-Apps. (freshworks#344) * 📦 NEW: Voucher code generator * Address: Review #1 * Merge (#3) * Add newhire-onboarding-invites * Update README * [MP-10156] Newhire Onboarding Invites for freshteam * [MP-10156] Newhire Onboarding invites for freshteam * [MP-10156] name changed to newhire-onboarding-invites * [MP-10156] newhire-onboarding-invites * [MP-10156] generate operations fields * [DemoApps] Domain whitelisting, Iparams re-org * [DEVREL-1166] Tweak: Spinner in Joke component (freshworks#331) * Add: config-iparams-html-freshservice * New: config-iparams-html-freshservice * Twek: Joke Components Add: spinner as a loding sign during the API request phase * Tweak: Joke component at full_page * Update: Incorporated Review:1 * Update: Code Format * Update: Punchline via Dependency Injection * 🐛 FIX: whitelisting changes (freshworks#341) * 🐛 FIX: whitelisting changes * 📖 DOC: replace screenshots and features demonstrated * 👌 IMPROVE: add whitelisting domain support (freshworks#342) * 👌 IMPROVE: add whitelisting domain support * 📖 DOC: list features demonstrated * [DEVREL-1180] Refactor: Ticket-merger Freshdesk sample-app (freshworks#340) * ♻️ Refactor: Ticker Merger * rm: .gitignore * Security fixes for Demo Apps dir (#2) * Revert "[DEVREL-1180] Refactor: Ticket-merger Freshdesk sample-app (freshworks#340)" This reverts commit c068b68. * Revert "👌 IMPROVE: add whitelisting domain support (freshworks#342)" This reverts commit 2b451e4. * Revert "🐛 FIX: whitelisting changes (freshworks#341)" This reverts commit bc05622. * Revert "[DEVREL-1166] Tweak: Spinner in Joke component (freshworks#331)" This reverts commit e42ea10. * New line to files * `request_api` whitelisting: httpbin -> xkcd API * Fix `authentication_basic` app * `custom_entities` app fix * [DemoApps] Domain whitelisting, Iparams re-org * New line to files * [DEVREL-1166] Tweak: Spinner in Joke component (freshworks#331) * Add: config-iparams-html-freshservice * New: config-iparams-html-freshservice * Twek: Joke Components Add: spinner as a loding sign during the API request phase * Tweak: Joke component at full_page * Update: Incorporated Review:1 * Update: Code Format * Update: Punchline via Dependency Injection * 🐛 FIX: whitelisting changes (freshworks#341) * 🐛 FIX: whitelisting changes * 📖 DOC: replace screenshots and features demonstrated * 👌 IMPROVE: add whitelisting domain support (freshworks#342) * 👌 IMPROVE: add whitelisting domain support * 📖 DOC: list features demonstrated * [DEVREL-1180] Refactor: Ticket-merger Freshdesk sample-app (freshworks#340) * ♻️ Refactor: Ticker Merger * rm: .gitignore * Security fixes for Demo Apps dir (#2) * Revert "[DEVREL-1180] Refactor: Ticket-merger Freshdesk sample-app (freshworks#340)" This reverts commit c068b68. * Revert "👌 IMPROVE: add whitelisting domain support (freshworks#342)" This reverts commit 2b451e4. * Revert "🐛 FIX: whitelisting changes (freshworks#341)" This reverts commit bc05622. * Revert "[DEVREL-1166] Tweak: Spinner in Joke component (freshworks#331)" This reverts commit e42ea10. * `request_api` whitelisting: httpbin -> xkcd API * Fix `authentication_basic` app * `custom_entities` app fix * Fix log * Used aws-sdk/client-organizations * `config-iparams-html-freshdesk` whitelisting fix * `config-iparams-html-freshservice` whitelisting fix * `config-iparams-json-freshdesk` whitelisting fix * `config-iparams-json-freshservice` whitelisting * `config-placeholders-freshdesk` whitelisting fix * `custom_installation_page_app` whitelisting * `dynamic_iparams` disclaimer and whitelisting * `ticket_details_freshservice_app` Remove iparams_test_data * `Ticket_creator` app - scope, CDN, whitelisting fixes * `Github_Issue_Creator` CDN, bug fix, whitelisting, scope change * `config-iparams-json-freshservice` minor fixes Co-authored-by: Hamsini-Sivalenka <hamsini.sivalenka@freshworks.com> Co-authored-by: Teja Kummarikuntla <teja.kummarikuntla@freshworks.com> Co-authored-by: Shaik Saif Ali <saifali.shaik@freshworks.com> Co-authored-by: Teja Kummarikuntla <teja.kummarikuntla@freshworks.com> Co-authored-by: Hamsini-Sivalenka <hamsini.sivalenka@freshworks.com> Co-authored-by: Shaik Saif Ali <saifali.shaik@freshworks.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.