Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Switched to pytest suite #131

Merged
merged 9 commits into from
May 9, 2021
Merged

test: Switched to pytest suite #131

merged 9 commits into from
May 9, 2021

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented May 9, 2021

This PR introduces the following modifications:

  • switched the entire test suite from unittest to pytest
  • fixed complement_cross_entropy in place ops
  • removed OneCycle since it has been integrated into PyTorch
  • revamped README
  • updated CONTRIBUTING
  • updated CI job & requirements

@frgfm frgfm added topic: documentation Improvements or additions to documentation type: enhancement New feature or request module: nn topic: build Related to build and installation ext: tests Related to test labels May 9, 2021
@frgfm frgfm added this to the 0.1.4 milestone May 9, 2021
@frgfm frgfm self-assigned this May 9, 2021
@codecov
Copy link

codecov bot commented May 9, 2021

Codecov Report

Merging #131 (76dc4ec) into master (cb4b906) will increase coverage by 0.55%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   91.03%   91.59%   +0.55%     
==========================================
  Files          51       50       -1     
  Lines        2935     2866      -69     
==========================================
- Hits         2672     2625      -47     
+ Misses        263      241      -22     
Impacted Files Coverage Δ
holocron/optim/__init__.py 100.00% <ø> (ø)
holocron/nn/functional.py 92.57% <75.00%> (-3.97%) ⬇️
holocron/optim/lars.py 63.63% <0.00%> (-1.82%) ⬇️
holocron/optim/lamb.py 81.81% <0.00%> (-1.82%) ⬇️
holocron/optim/ralars.py 80.59% <0.00%> (-1.50%) ⬇️
holocron/models/detection/yolov4.py 97.54% <0.00%> (-0.50%) ⬇️
holocron/nn/modules/activation.py 95.45% <0.00%> (ø)
holocron/nn/modules/loss.py 93.75% <0.00%> (+1.25%) ⬆️

@frgfm frgfm merged commit de25835 into master May 9, 2021
@frgfm frgfm deleted the pytest branch May 9, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: docs ext: tests Related to test module: nn module: optim topic: build Related to build and installation topic: ci topic: documentation Improvements or additions to documentation type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant