Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed progress bar of LR Finder for other backends #39

Merged
merged 1 commit into from
May 27, 2020

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented May 27, 2020

This PR fixes constant line breaks on notebook backend by importing tqdm from the auto submodule, as suggested here.

@frgfm frgfm added type: enhancement New feature or request module: utils labels May 27, 2020
@frgfm frgfm added this to the 0.1.2 milestone May 27, 2020
@frgfm frgfm self-assigned this May 27, 2020
@frgfm frgfm changed the title fix: Fixed progress bar of LR Finder for other backend fix: Fixed progress bar of LR Finder for other backends May 27, 2020
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   75.11%   75.11%           
=======================================
  Files          27       27           
  Lines        1326     1326           
=======================================
  Hits          996      996           
  Misses        330      330           
Impacted Files Coverage Δ
holocron/utils/misc.py 90.90% <100.00%> (ø)

@frgfm frgfm merged commit cf3f5fc into master May 27, 2020
@frgfm frgfm deleted the lrfinder-bar branch May 27, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant