Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved YOLO concatdownsample layer's efficiency #48

Merged
merged 3 commits into from
Jun 26, 2020
Merged

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Jun 25, 2020

This PR improves the concatenated downsampling operation of YOLO architectures by:

  • discarding the channel order and switching to torch.cat to increase inference speed
  • updating unittest
  • updating default object detection argument

@frgfm frgfm added this to the 0.1.2 milestone Jun 25, 2020
@frgfm frgfm self-assigned this Jun 25, 2020
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #48 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   85.36%   85.33%   -0.03%     
==========================================
  Files          29       29              
  Lines        1524     1521       -3     
==========================================
- Hits         1301     1298       -3     
  Misses        223      223              
Impacted Files Coverage Δ
holocron/nn/functional.py 94.79% <100.00%> (-0.16%) ⬇️
holocron/nn/modules/conv.py 100.00% <100.00%> (ø)

@frgfm frgfm merged commit 880489c into master Jun 26, 2020
@frgfm frgfm deleted the yolo-optim branch June 26, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant