Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added possibility to retrieve multiple CAMs in demo #105

Merged
merged 6 commits into from
Oct 31, 2021
Merged

feat: Added possibility to retrieve multiple CAMs in demo #105

merged 6 commits into from
Oct 31, 2021

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Oct 31, 2021

This PR introduces the following modifications:

  • fixed typing of CAM constructors
  • extended arg type support of base CAM
  • updated unittest
  • added support of multiple layers in demo

@frgfm frgfm added type: improvement New feature or request ext: tests Related to test module: methods Related to torchcam.methods ext: demo labels Oct 31, 2021
@frgfm frgfm added this to the 0.3.1 milestone Oct 31, 2021
@frgfm frgfm self-assigned this Oct 31, 2021
@codecov
Copy link

codecov bot commented Oct 31, 2021 •
edited
Loading

Codecov Report

Merging #105 (110e301) into master (0127071) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files           7        7           
  Lines         347      347           
=======================================
  Hits          335      335           
  Misses         12       12
Impacted Files Coverage Δ
torchcam/cams/core.py 96.46% <ø> (ø)
torchcam/cams/gradcam.py 98.83% <ø> (ø)
torchcam/cams/cam.py 96.84% <100.00%> (ø)

@frgfm frgfm merged commit 8abb3ea into master Oct 31, 2021
@frgfm frgfm deleted the demo-fuse branch October 31, 2021 16:48
@frgfm frgfm mentioned this pull request Nov 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frgfm frgfm

Labels
ext: demo ext: tests Related to test module: methods Related to torchcam.methods type: improvement New feature or request
Projects
None yet
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.
1 participant
@frgfm