Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improved target resolution #174

Merged
merged 2 commits into from Aug 1, 2022
Merged

refactor: Improved target resolution #174

merged 2 commits into from Aug 1, 2022

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Aug 1, 2022

This PR introduces the following modifications:

  • improves the target resolution
  • adds a unittest for mobilenet V3 large (which was failing before)

@frgfm frgfm added type: improvement New feature or request module: methods Related to torchcam.methods labels Aug 1, 2022
@frgfm frgfm added this to the 0.4.0 milestone Aug 1, 2022
@frgfm frgfm self-assigned this Aug 1, 2022
@frgfm frgfm mentioned this pull request Aug 1, 2022
8 tasks
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #174 (4a0f35f) into main (a5c6c51) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files           7        7           
  Lines         387      387           
=======================================
  Hits          374      374           
  Misses         13       13           
Impacted Files Coverage Δ
torchcam/methods/activation.py 97.56% <ø> (ø)
torchcam/methods/gradient.py 98.93% <ø> (ø)
torchcam/utils.py 84.61% <ø> (ø)
torchcam/methods/_utils.py 100.00% <100.00%> (ø)

@frgfm frgfm merged commit 7e1a328 into main Aug 1, 2022
@frgfm frgfm deleted the target-resolution branch August 1, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: methods Related to torchcam.methods type: improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant