Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid hidden folders in the spec (already forbidden in JSON Schema) #19

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

roll
Copy link
Member

@roll roll commented Jan 26, 2024


Rationale

See frictionlessdata/specs#802. Note that although it's forbidden for data publishing it's ok for implementations to support it for local work (e.g. frictionless-py has trusted flag)

@roll
Copy link
Member Author

roll commented Feb 19, 2024

@khusmann
@ezwelty
@pwalsh
@PietrH

Can you please take a look -- we need one more vote to accept this change

Copy link

@nichtich nichtich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment: I'd remove the sentence "and implementations SHOULD NOT support these path types." as it might be confusing what is actually wanted.

Copy link

cloudflare-pages bot commented Feb 19, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5c5dbcd
Status: ✅  Deploy successful!
Preview URL: https://c851e8bc.datapackage.pages.dev
Branch Preview URL: https://802-clarify-dot-folders.datapackage.pages.dev

View logs

@roll
Copy link
Member Author

roll commented Feb 19, 2024

@nichtich
Thanks! Done

@roll roll added the candidate label Feb 19, 2024
@roll
Copy link
Member Author

roll commented Feb 19, 2024

Thanks!

ACCEPTED by the WG (6/9)

@roll roll merged commit d8969ad into main Feb 19, 2024
1 check passed
@roll roll deleted the 802/clarify-dot-folders branch February 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If the folder name starts with a dot(.), the result of path pattern check is true negative
2 participants