Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP - field "hash" in resource information is unclear. #41

Closed
relet opened this issue Apr 24, 2013 · 4 comments
Closed

DP - field "hash" in resource information is unclear. #41

relet opened this issue Apr 24, 2013 · 4 comments

Comments

@relet
Copy link

relet commented Apr 24, 2013

Is it a checksum?
Should it include the algorithm? Should it allow for several algorithms? Should it require certain algorithms?

"hash":"28cb0cb25701a242d84c2857fdf52775" 

or

"hash":{
  "md5":"28cb0cb25701a242d84c2857fdf52775",
  "sha256":"..."
}

?

@rufuspollock
Copy link
Contributor

Yes it is a checksum. Options:

  • Set one and only one option (e.g. md5 or sha256). md5 is attractive as common (cf s3) but has vulnerabilities.
  • Have (and require) a prefix: e.g. "md5:{hash}" or "sha256:{hash}"
  • Have a default and allow specification of a prefix
  • Allow multiple hashes as per the suggestion above

I would incline to either option 1 or 4.

@relet
Copy link
Author

relet commented Apr 24, 2013

All are valid options if the standard itself is versioned -
having just one option is easier on the tools (they have to implement all options if datasets can present either).

@rufuspollock
Copy link
Contributor

OK, i'm going to recommend option 1 and recommend md5 (following s3 etc).

@rufuspollock
Copy link
Contributor

@relet thank-you very much for the issue and the suggestions here. As per discussion have resolved by clarifying this is md5 and there is only one hash field.

roll added a commit that referenced this issue Jun 26, 2024
* Added general/csv props

* Added excel/db

* Added json

* Updated profile section

* Updated the profile

* Fixed spelling

* Removed db for now; focus on csv/json/excel at the beggining

* Updated CSV Dialect mention

* Fixed quoteChar

* Fixed doubleQuote

* Fixed header

* Updated introduction

* Fixed the link

* Update content/docs/specifications/table-dialect.md

Co-authored-by: Peter Desmet <peter.desmet@inbo.be>

* Update content/docs/specifications/table-dialect.md

Co-authored-by: Peter Desmet <peter.desmet@inbo.be>

* Update content/docs/specifications/table-dialect.md

Co-authored-by: Peter Desmet <peter.desmet@inbo.be>

* Added caseSensitiveHeader note

---------

Co-authored-by: Peter Desmet <peter.desmet@inbo.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants