Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #127

Closed
1 of 2 tasks
roll opened this issue Oct 10, 2016 · 4 comments
Closed
1 of 2 tasks

Improve test coverage #127

roll opened this issue Oct 10, 2016 · 4 comments
Labels
general General improvements

Comments

@roll
Copy link
Member

roll commented Oct 10, 2016 •
edited
Loading

Description

We need to test all edge-cases etc. Many prev version data examples are in data folder.

Tasks

  • improve test coverage
  • set coverage threshold in coverals to 90%
@roll roll added general General improvements branch-next labels Oct 10, 2016
@roll roll added this to the goodtables-v1 milestone Oct 10, 2016
@roll roll self-assigned this Oct 10, 2016
@roll roll added the priority label Oct 10, 2016
@roll roll mentioned this issue Oct 12, 2016
Merged
@roll roll added current and removed priority labels Oct 18, 2016
This was referenced Oct 27, 2016
Closed
Merged
@roll roll added review and removed current labels Nov 1, 2016
@roll roll changed the title Use as much as possible current test examples with next codebase Use as much as possible goodtables-v0.7 test examples Nov 1, 2016
@roll roll modified the milestone: goodtables-v1 Nov 1, 2016
roll pushed a commit that referenced this issue Nov 2, 2016
Improved tests (#127)
ef1a5b8 
* added prev version data examples

* implemented feature tests

* moved files to data

* updated verson

* added features

* marked spec test as xfail
@roll roll added priority and removed review labels Nov 2, 2016
roll pushed a commit that referenced this issue Nov 2, 2016
[BREAKING] Rebased on goodtables.next codebase (#120)
467b349 
* Rebased on goodtables.next codebase (#118)

* removed current codebase

* added updated codebase

* fixed linting

* updated readme

* updated readme

* updated readme

* fixed source checks

* added dataset checks

* min style change

* removed ecode filter from filter_checks

* renamed cells back to columns + row_number

* added dataset check stubs

* implemented dataset checks

* fixed linting

* moved __inspect_table next to inspect for better reading

* fixed list.clear for python2

* added error limit to dataset errors

* updated readme

* updated readme

* added breaking note to readme

* added custom checks support

* implemented custom profiles

* fixed linting

* added options order_fields and infer_fields

* fixed extra_header

* added comments

* updated spec

* renamed unordered_headers to non_matching_header

* renamed col-number to column-number

* min

* updated added dataset errors to readme

* splitted error and check concpets

* fixed linting

* min

* fixed readme

* updated readme

* updated readme

* fixed readme

* fixed readme

* added guard assertion to checks

* updated custom checks API

* fixed linting, readme

* fixed linting, readme

* updated readme

* updated readme

* typo

* moved table errors to Inspector, deleted checks

* added ability to profilies to return errors

* fixed head checks not columns break

* rebased check on in-place erorrs update

* rebased profiles on in-place errors

* fixed readme

* fixed readme

* fixed readme

* fixed readme

* fixed readme

* no extra-header error if infer_fields is True

* implemented proper non-matching-header without ordering

* added custom_profiles, custom_checks arguments instead of global
registry

* moved default args to signatures

* removed make release (use github releases instead!)

* added return code to cli

* improved cli error formatting

* improved error messages, tests

* updated examples

* added custom examples

* added inspector tests

* added limit tests

* fixed tests

* fixed spec link

* added checks options to cli

* fixed profiles

* added description to setup

* added entry_points, keywords

* moved ckan profile to examples

* removed report from spec

* updated version to v1

* updated install instruction for now

* Fixed jsontableschema-error message (#133)

* Rebased on granular tabulator exceptions (#115)

* updated dependencies

* rebases on new tabulator exceptions

* Renamed profile to preset with simplified API (#124)

* renamed profile to preset

* removed errors, tables arguments from preset

* Added infer_schema option, updated preset API (#128)

* minor improvements

* added infer_schema option false by default

* Added support for schema constraints (#55)

* updated jsontableschema version

* implemented all constraints except unique

* implemented unique constraint check

* updated to jsontableschema-v0.8.2

* fixed linting

* Added tables preset (#125)

* added tables preset

* fixed linting

* added tables test

* Implemented order_fields option (#123)

* fixed column producing for body context

* removed column from schema checks only if name slugs are different

* implemented order_fields algo

* improved comments

* Rebased on external spec (#131)

Rebased on external spec

* Improved tests (#127)

* added prev version data examples

* implemented feature tests

* moved files to data

* updated verson

* added features

* marked spec test as xfail

* Rebased on spec-v1.0.0-alpha1 (#131)

* updated spec, added spec to API

* added config with checks order

* rebased in inspector on updated spec

* updated @check API

* rebased on spec message templates

* fixed cutom checks

* fixed linting

* Updated readme note
@pwalsh
Copy link
Member

pwalsh commented Nov 2, 2016

@roll I;m fine with you closing this now, with the file additions you added.

@roll roll changed the title Use as much as possible goodtables-v0.7 test examples Improve test coverage Nov 2, 2016
@roll
Copy link
Member Author

roll commented Nov 2, 2016

I prefer to improve test coverage before final release. Now it's just 83% and some edge-cases - https://github.com/frictionlessdata/goodtables-py/issues?q=is%3Aissue+is%3Aopen+label%3Abug - are not covered.

@roll roll added the [2d] label Dec 8, 2016
@roll roll added (py) and removed (py) labels Jan 16, 2017
@roll roll removed the [2d] label Feb 25, 2017
@roll
Copy link
Member Author

roll commented May 24, 2017

MERGED #105

@roll roll closed this as completed May 24, 2017
@roll roll removed the planned label May 24, 2017
@roll roll reopened this Jul 12, 2017
@roll roll removed this from the Version-1 milestone Jul 12, 2017
@roll roll mentioned this issue Jul 12, 2017
Closed
18 tasks
@roll roll removed their assignment Jul 12, 2017
@roll
Copy link
Member Author

roll commented Aug 4, 2017

DONE

@roll roll closed this as completed Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
general General improvements
Projects
Open Knowledge
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roll @pwalsh