Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tests #145

Merged
merged 6 commits into from
Nov 2, 2016
Merged

Improved tests #145

merged 6 commits into from
Nov 2, 2016

Conversation

roll
Copy link
Member

@roll roll commented Nov 1, 2016


This is not covering all current goodtables data examples and test cases. We need to address full coverage later in #127.

@roll roll added the review label Nov 1, 2016
@roll roll changed the title [WIP] Improved tests Improved tests Nov 1, 2016
@roll
Copy link
Member Author

roll commented Nov 1, 2016

@pwalsh
could you please review?

@pwalsh
Copy link
Member

pwalsh commented Nov 1, 2016

@roll all good. Are we sure that it is not better to just put this stuff in testsuite and not keep all these files in here anymore?

Copy link
Member

@pwalsh pwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but option open to move this all to testsuite, which makes more sense to me.

@roll
Copy link
Member Author

roll commented Nov 2, 2016

@pwalsh
I think there are a few things:

  • we definitely should reduce amount of data examples here because many of them just a duplication and I suppose we lack some edge-case about csv dialects, broken encoding etc
  • but still if we could provide complete test coverage (including high-level tests) on the library level - let's do it! We need great coverage on lib level to work further - accepts PRs, refactor etc. With instant feedback in dev and CI.
  • so testsuite role here - to have tests which guarantee that our stack works good together (e.g. tabulator update -> tabulator tests good -> testsuite goodtables tests fail -> we've missed breaking change on tabulator level) and works after every master/PyPi change. In my opinion it doesn't mean we need just automatically move all high-level tests to testsuite - only if we can't have it on the lib level (like datapackage + jsontableschema-sql integration)

@roll roll merged commit ef1a5b8 into next Nov 2, 2016
@roll roll deleted the improved-tests branch November 2, 2016 06:29
@roll roll added duplicate This issue or pull request already exists and removed review duplicate This issue or pull request already exists labels Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants