Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing normal behaviours I broke, my bad #253

Conversation

@paulgirard
Copy link
Contributor

paulgirard commented Sep 26, 2019


My previous PR introduced bugs...
My fix was too quick and broke previous behaviours.
Should be better like this. Tests passed.

I took the liberty to change the valid variable name to make the principles more explicit.
Also if the reference table is missing is considered the same thing as original row empty.
I would have raised an exception is such a case but I only left a comment about this.

paulgirard added 2 commits Sep 26, 2019
@roll
roll approved these changes Sep 27, 2019
@roll roll merged commit 3c02525 into frictionlessdata:master Sep 27, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.09%) to 91.667%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.