Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing normal behaviours I broke, my bad #253

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 13 additions & 12 deletions tableschema/table.py
Expand Up @@ -116,14 +116,15 @@ def iter(self, keyed=False, extended=False, cast=True, relations=False):
message = 'Foreign key "%s" violation in row "%s"'
message = message % (foreign_key['fields'], row_number)
raise exceptions.RelationError(message)
else:
elif type(refValue) is dict:
for field in foreign_key['fields']:
if type(row_with_relations[field]) is not dict:
# no previous refValues injected on this field
row_with_relations[field] = refValue
else:
# alreayd one ref, merging
row_with_relations[field].update(refValue)

# mutate row now that we are done, in the right order
row = [row_with_relations[f] for f in headers]

Expand Down Expand Up @@ -243,27 +244,27 @@ def _resolve_relations(row, headers, relations, foreign_key):
fields = list(zip(foreign_key['fields'], foreign_key['reference']['fields']))
reference = relations.get(foreign_key['reference']['resource'])
if not reference:
return row
# should an exception beeing raised here ?
return None

# Collect values - valid if all None
values = {}
valid = True
empty_row = True
for field, ref_field in fields:
if field and ref_field:
values[ref_field] = keyed_row[field]
if keyed_row[field] is not None:
valid = False
empty_row = False

# Resolve values - valid if match found
if not valid:
if not empty_row:
for refValues in reference:
if set(values.items()).issubset(set(refValues.items())):
for field, ref_field in fields:
keyed_row[field] = refValues
valid = True
break
if valid:
# return the correct reference values
return refValues
# return the correct reference values
return refValues

if empty_row:
# return the orignal row if empty
return row
else:
return None