Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Setup Error On Windows #204

Merged
merged 1 commit into from
May 3, 2022
Merged

Fix Setup Error On Windows #204

merged 1 commit into from
May 3, 2022

Conversation

serfend
Copy link
Contributor

@serfend serfend commented Apr 26, 2022

No description provided.

@oleavr
Copy link
Member

oleavr commented Apr 27, 2022

Thanks! Does this happen on Python 2.x or 3.x?

@serfend
Copy link
Contributor Author

serfend commented Apr 28, 2022

i tested in Python 3.10 , it seems cause by directly concat str with bytes.

@oleavr
Copy link
Member

oleavr commented May 3, 2022

Ah. This was actually already fixed by @X5tar in dd89460. I've updated your commit to improve that fix instead, so it no longer depends on Python >= 3.6. Cheers!

@oleavr oleavr merged commit a6d23a7 into frida:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serfend @oleavr